#5492 closed Bugs (Invalid)

RTMP url parsing bug for url that contains semi-colon

Reported by: zoltar12 Owned by:
Priority: 4 - Normal
Component: Streaming (Internet) Version: GIT
Severity: Normal Keywords: RTMP
Cc: spiff, vulkanr, elupus, AreaScout Blocked By:
Blocking: Platform: All

Description

Url such as

rtmp://89.149.169.148:1.935/ondemand?_fcs_vhost=cp39465.hulu.com&auth=daEcKd7aoctaNd8dta3dmdecCaQamcmbOak-bjqW4E-8-2qOBvEwYJAm&aifp=NS20070910&slist=con.tent/39484/12/505/HuluTranscode_51554_40967_FLASH_700K_16x9_29_97__RA+4HFwY1EWq-4TohnbLtA; international=false

Connects to the server properly, but when the play command issues

content/39484/12/505/HuluTranscode_51554_40967_FLASH_700K_16x9_29_97RA+4HFwY1EWq-4TohnbLtA; international=false

the server is expecting

content/39484/12/505/HuluTranscode_51554_40967_FLASH_700K_16x9_29_97RA+4HFwY1EWq-4TohnbLtA

Attachments (1)

rtmp.cpp (26.7 KB) - added by zoltar12 at 2008-12-15T16:12:16Z.

Change History (9)

Changed at 2008-12-15T16:12:16Z by zoltar12

comment:1 in reply to: ↑ description Changed at 2008-12-15T16:22:55Z by zoltar12

rtmp.cpp contains the fix.

These are the added lines in CRTMP::SendPlay()

if (!strPlay.IsEmpty())
{
int nSemiColonPos = strPlay.find(";");
if ( nSemiColonPos > 0 )
{
strPlay = strPlay.Mid(0, nSemiColonPos);
}
}

comment:2 Changed at 2008-12-27T23:34:38Z by Gamester17

  • Cc spiff vulkanr elupus added

comment:3 Changed at 2009-01-02T13:17:43Z by Gamester17

  • Cc AreaScot arnova added
  • Keywords RTMP added; rtmp removed

Has anyone reviewed the potential fix for this mentioned here by zoltar12?

comment:4 Changed at 2009-01-02T13:40:09Z by Gamester17

  • Cc AreaScout added; AreaScot removed

comment:5 Changed at 2009-01-02T17:59:15Z by rwparris2

I'm not so sure this is an actual bug.

Reformatting the url and setting the playPath property makes this issue mute (at least for Hulu).

If anyone is interested I can post how BlueCop from the forums passes the rtmp url to xbmc for Hulu.

I'm not sure if this will still cause problems for other sites though... maybe someone more familiar with the RTMP Library could comment.

comment:6 Changed at 2009-04-03T21:46:20+01:00 by jmarshall

Indeed, stripping stuff off the URL somewhat arbitrarily sounds like an incorrect fix to me.

comment:7 Changed at 2009-04-03T21:56:35+01:00 by arnova

  • Cc arnova removed

comment:8 Changed at 2009-04-12T08:45:24+01:00 by jmarshall

  • Milestone 9.04 deleted
  • Resolution set to Invalid
  • Status changed from new to closed

Closing, given that the proposed solution isn't a real one, and that there appears to be ways to do it already.

Note: See TracTickets for help on using tickets.