#17478 new Bugs

Favourites can't ever be reloaded - specifically on profile change

Reported by: trogggy Owned by:
Priority: 4 - Normal
Component: Other (un-categorized if does not fit anywhere else) Version: 18.0 "Leia" Alpha1
Severity: Normal Keywords: favourites
Cc: takoi Blocked By:
Blocking: Platform: All


Since https://github.com/xbmc/xbmc/pull/11967 favourites are read on startup and can't be reloaded. This causes problems if you're trying to manually add or edit favourites, as the only way to get changes to show up seems to be to re-start kodi. Same applies on a profile change - favourites are not reloaded so if profile x is loaded the favourites from that profile are ignored and those from the original profile are still loaded. I don't think a debug log is going to show anything that isn't obvious - happy to provide one if needed. How to reproduce the issue:

  1. Start kodi. Make a manual edit to favourites.xml. Load favourites. Your changes are not reflected in the favourites dialog. I understand the caching is by design but would plead(!) for an option to refresh from favourites.xml for usability / to keep current function.
  2. Start kodi. Change profile. Opening favourites in new profile still loads favourites from original profile. Again, a function to refresh favourites on a profile change would address this.

Couple of forum threads re this: http://forum.kodi.tv/showthread.php?tid=314724 http://forum.kodi.tv/showthread.php?tid=313569 Thanks for your attention.

Change History (6)

comment:1 Changed at 2017-05-22T10:50:33+01:00 by ksooo

  • Cc tamland added

comment:2 Changed at 2017-05-22T10:53:00+01:00 by ksooo

  • Cc takoi added; tamland removed

comment:3 Changed at 2017-05-23T17:44:49+01:00 by agb2

The pull referred to above talks about a 'favourites service' to manage the favourites, caching etc. It sounds as though this 'service' should be restarted on login to a different profile.

comment:5 Changed at 2017-06-06T20:54:59+01:00 by trogggy

Thanks for the update. Is there any intention to allow a user-controlled reload of favourites?

comment:6 Changed at 2018-12-18T13:14:46Z by JimmySmith2


This break shared data concept. I used not only MySQL DB to share watch status/library among clients @home, but also favourites.. It doesnt make much sense to have different favourites in living room / bed room etc.). Therefore, I have favourites on shared network drive, to be able to edit them on one place, and other clients pick them up automatically.

With this change, its not even possible to trigger reload from the JSON / etc. I can understand, that someone wants to break automatic refresh (maybe fro performance reason?), but I dont get why this change is done without option to refresh favourites by a trigger, so I can script the same behauviour, at least.

Last edited at 2018-12-18T13:16:24Z by JimmySmith2 (previous) (diff)
Note: See TracTickets for help on using tickets.