Opened 4 years ago

Closed 4 years ago

#13068 closed Bugs (Fixed)

[PATCH] Infinite loop in SMB directory handling

Reported by: ServerAlex Owned by: jmarshall
Priority: 4 - Normal Milestone: 12.0 "Frodo"
Component: File Manager Version: GIT
Severity: Normal Keywords:
Cc: elupus Blocked By:
Blocking: Platform: All


Commit e2224e18d53bc7873c3b47e39e4628d2724a5df0 for xbmc/filesystem/SMBDirectory.cpp produced an infinite loop in SMB directory handling. Please apply the attached patch file.

Attachments (1)

0001-Fixes-infinite-loop-in-SMB-directory-code.patch (1.2 KB) - added by ServerAlex 4 years ago.
Fixes the bug

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by ServerAlex

Fixes the bug

comment:1 Changed 4 years ago by jmarshall

  • Cc elupus added
  • Milestone changed from Future / Pending to 12.0

Thanks. It's not clear to me why a do or while loop is needed here at all??


comment:2 Changed 4 years ago by jmarshall

Hmm, I guess it's to save a bunch of nested if's. A break at the end of the while() would be just as good though (and a one-liner...)

@elupus - you happy with that?

comment:3 Changed 4 years ago by elupus

I'm fine with eiher.

comment:4 Changed 4 years ago by jmarshall

  • Owner set to jmarshall
  • Status changed from new to accepted

I'll slot a break in in that case.

comment:5 Changed 4 years ago by jmarshall

  • Resolution set to Fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.